Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force AAC 5.1 to AC3 5.1 #1979

Open
closesim opened this issue Oct 8, 2024 · 13 comments · May be fixed by #2003
Open

Force AAC 5.1 to AC3 5.1 #1979

closesim opened this issue Oct 8, 2024 · 13 comments · May be fixed by #2003
Assignees
Labels
enhancement New feature or request

Comments

@closesim
Copy link

closesim commented Oct 8, 2024

Hi. I'm not sure if this a bug or misconfiguration. Assume a video container with HEVC and AAC 5.1 normally gets direct play without ttanscoding in a Roku Ultra LT. In this scenario the Roku appears to handle the audio stream and mixes it to stereo automatically even though the Receiver supports 5.1 PCM. I was expecting that Jellyfin could remix the audio to AC3 or EAC3 to allow bitstreaming to a Receiver without losing the dynamic range and bandwidth of the 5.1 stream.

Describe the solution you'd like

An option to force transcoding AAC multichannel to Dolby based multichannel format that can be supported with devices with eARC, ARC or directly connected to a Dolby supported Receiver, with the original video stream.

Describe alternatives you've considered

The Roku mixes all multichannel AAC to Stereo in all scenarios.

Additional context

My setup consist in a Roku Ultra LT connected to a Jellyfin Docker container over wifi. The Roku is also connected to a Onkyo Receiver over HDMI.

Related issue:
#117 (comment)

@closesim closesim added the enhancement New feature or request label Oct 8, 2024
@closesim closesim changed the title AAC 5.1 to AC3 5.1 Force AAC 5.1 to AC3 5.1 Oct 8, 2024
@cewert
Copy link
Member

cewert commented Oct 8, 2024

I took a stab at this once. I plan on giving it another shot but don't know when that will be #1466

@dathbe
Copy link

dathbe commented Oct 11, 2024

Are you sure this is a Roku issue? I had this issue, but after I looked deep in the manuals for my receiver I found that my receiver does not like AAC >2.0. I've just encoded everything as AC3 for that reason.

@closesim
Copy link
Author

You can't send AAC over HDMI. Roku processes the multichannel AAC audio to Stereo PCM and then sends the PCM stream to the receiver. And yes, I know one can manually add the AC3 track to the server as an .ac3 file. But I want Jellyfin handle that hazle for me.

@dathbe
Copy link

dathbe commented Oct 11, 2024

You can't send AAC over HDMI.

Interesting. Did not know this.

And yes, I know one can manually add the AC3 track to the server as an .ac3 file. But I want Jellyfin handle that hazle for me.

Fair. Though I just go with AC3 from the outset now since it seems to be the most compatible. EAC3 is also pretty universal (at least with my setups), but FFMPEG does a terrible job of encoding it. Even if Jellyfin took care of converting the audio for me, I'd prefer to avoid the lossy conversion.

@Alliyance
Copy link

Alliyance commented Oct 17, 2024

I vote to leave it like it is. The last time AAC 5.1 got transcoded, I had an issue with the audio that went out of sync.
Or if it's possible to make that change only for HEVC files, That would be fantastic.

@cewert cewert self-assigned this Oct 20, 2024
@cewert cewert linked a pull request Oct 20, 2024 that will close this issue
@cewert
Copy link
Member

cewert commented Oct 20, 2024

Would love some help testing #2003

@closesim
Copy link
Author

I might give it a go. If the README.md instructions are as straightforward as they look.

@cewert
Copy link
Member

cewert commented Oct 21, 2024

They are just use this zip file for step 2 https://github.com/jellyfin/jellyfin-roku/actions/runs/11430399148?pr=2003

@dathbe
Copy link

dathbe commented Oct 21, 2024

I'm just getting an endless black screen with the time in the top right corner when I try to play any file (tested with mkv if somehow that matters) after side loading the Dev app. The time does not change, suggesting the app is frozen. The only way to exit the black screen is to press the Home button. I'd send logs, but I don't know where to find logs for my Roku.

I tested it on two different devices - a Roku TV, and a Roku 4k Stick.

@closesim
Copy link
Author

Hi, I tested the build. Same as @dathbe, the app locked up. Nothing reported on the server logs (no transcoding logs).

@Alliyance
Copy link

Thanks @cewert . That is a lot better than just transcode all AAC5.1 to AC35.1.

Quick question, do you know if the Subs are working in the latest update (version 2.2.1)?

@dathbe
Copy link

dathbe commented Oct 23, 2024

Quick question, do you know if the Subs are working in the latest update (version 2.2.1)?

This is off topic now, but subs are working fine for me in 2.2.1. I didn't have a problem in 2.2.0, though.

@Alliyance
Copy link

@dathbe

Sorry for the off topic but a big thanks for replying. Just tested and they are working fine. Not sure why it wasn't working with version 2.2.0. Sometimes issues happened for unknown reason. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants