Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading spinner blocks the back button #1381

Closed
sevenrats opened this issue Sep 17, 2023 · 1 comment
Closed

loading spinner blocks the back button #1381

sevenrats opened this issue Sep 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@sevenrats
Copy link
Member

sevenrats commented Sep 17, 2023

maybe this is how we want it to behave so that we don't have to deal with the complexity of task cancellation and what not. maybe just killing the dialog and popping a scene will be enough, but my fear is that if a media loading task is underway that this task will not cancel. So, either implement a simple listener to do close the dialog, or investigate what would be involved with making a more comprehensive solution (perhaps we could register the loaded task with the extended dialog object somehow, such that the task was killed on back press.)

@sevenrats sevenrats added the bug Something isn't working label Sep 17, 2023
@1hitsong
Copy link
Member

1hitsong commented Dec 2, 2023

Resolved by #1515

@1hitsong 1hitsong closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants