From 1e8bbc6a6a388015d6c07dab33836b1f59752fb8 Mon Sep 17 00:00:00 2001 From: F0x1 <39696712+F0x1@users.noreply.github.com> Date: Sun, 15 Dec 2024 13:33:16 -0800 Subject: [PATCH] Fix: Remove conflicting metadata assignments to resolve audio switching issue on Roku - Removed the line `m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle` from onAudioIndexChange() - Removed the line `m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex` from onSubtitleChange() - These removals address a race condition causing video playback to fail when switching audio tracks Fixes #2059 --- components/video/VideoPlayerView.bs | 2 -- 1 file changed, 2 deletions(-) diff --git a/components/video/VideoPlayerView.bs b/components/video/VideoPlayerView.bs index 02a58f454..098572638 100644 --- a/components/video/VideoPlayerView.bs +++ b/components/video/VideoPlayerView.bs @@ -330,7 +330,6 @@ sub onSubtitleChange() m.top.control = "stop" m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle - m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex m.LoadMetaDataTask.itemId = m.currentItem.id m.LoadMetaDataTask.observeField("content", "onVideoContentLoaded") m.LoadMetaDataTask.control = "RUN" @@ -346,7 +345,6 @@ sub onAudioIndexChange() m.top.control = "stop" - m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex m.LoadMetaDataTask.itemId = m.currentItem.id m.LoadMetaDataTask.observeField("content", "onVideoContentLoaded")