SAMI External subtitle does not show on Exoplayer and External Player

[gkswngh05]

Describe the bug

The subtitle does not show on Exoplayer and External Player when external subtitle format is SAMI(*.smi, *.sami).

jellyfin-android/app/src/main/java/org/jellyfin/mobile/player/source/JellyfinMediaSource.kt

Lines 89 to 92 in f1f7899

	if (mediaStream.deliveryMethod == SubtitleDeliveryMethod.EXTERNAL) {
	val deliveryUrl = mediaStream.deliveryUrl
	val mimeType = CodecHelpers.getSubtitleMimeType(mediaStream.codec)
	if (deliveryUrl != null && mimeType != null) {

When subtitle format is SAMI, mediaStream.codec returns "sami".
But "sami" is not defined in CodecHelpers.getSubtitleMimeType, so that function returns null.

jellyfin-android/app/src/main/java/org/jellyfin/mobile/player/deviceprofile/CodecHelpers.kt

Lines 243 to 254 in f1f7899

	fun getSubtitleMimeType(codec: String?): String? {
	return when (codec) {
	"srt", "subrip" -> MimeTypes.APPLICATION_SUBRIP
	"ssa", "ass" -> MimeTypes.TEXT_SSA
	"ttml" -> MimeTypes.APPLICATION_TTML
	"vtt", "webvtt" -> MimeTypes.TEXT_VTT
	"idx", "sub" -> MimeTypes.APPLICATION_VOBSUB
	"pgs", "pgssub" -> MimeTypes.APPLICATION_PGS
	"smi", "smil" -> "application/smil+xml"
	else -> null
	}
	}

Since Jellyfin server is converting SAMI subtitle to Subrip format before sending to client, a quick and dirty solution would be defining "sami" as MimeTypes.APPLICATION_SUBRIP.

 fun getSubtitleMimeType(codec: String?): String? { 
     return when (codec) { 
         "srt", "subrip" -> MimeTypes.APPLICATION_SUBRIP 
         "ssa", "ass" -> MimeTypes.TEXT_SSA 
         "ttml" -> MimeTypes.APPLICATION_TTML 
         "vtt", "webvtt" -> MimeTypes.TEXT_VTT 
         "idx", "sub" -> MimeTypes.APPLICATION_VOBSUB 
         "pgs", "pgssub" -> MimeTypes.APPLICATION_PGS 
         "smi", "smil" -> "application/smil+xml"
         "sami" -> MimeTypes.APPLICATION_SUBRIP
         else -> null 
     } 
 } 

Logs

No response

Application version

2.6.1

Where did you install the app from?

Google Play

Device information

Galaxy S23 Ultra

Android version

Android 14, One UI 6.1

Jellyfin server version

10.9.0

Which video player implementations does this bug apply to?

• Web player (default)
• Integrated player (ExoPlayer)
• External player (VLC, mpv, MX Player)

[gkswngh05]

Come to think about it, I think it might be the Jellyfin server's problem. I may have to investigate about it...
Edit: Nevermind.

[jellyfin-bot]

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

[gkswngh05]

The issue still persists on the Android client 2.6.2 and server version 10.9.11.

[ppskj178]

I had the same problem.
SMI is a popular enough format.
I hope it gets fixed soon.