Skip to content

Latest commit

 

History

History
135 lines (89 loc) · 3.45 KB

CONTRIBUTING.md

File metadata and controls

135 lines (89 loc) · 3.45 KB

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/jaysnm/dremio-arrow/issues.

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

dremio-arrow could always use more documentation, whether as part of the official dremio-arrow docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/jaysnm/dremio-arrow/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

Contribution Journey!

Ready to contribute? Here's how to set up dremio-arrow for local development.

  • Fork the dremio-arrow repo on GitHub.

  • Clone your fork locally

    $ git clone [email protected]:your_name_here/dremio-arrow.git

  • Ensure poetry is installed.

  • Install dependencies and start your virtualenv:

    $ poetry install -extras 'dev doc test'

  • configure pre-commit hooks

    poetry run pre-commit install
poetry run pre-commit install-hooks

  • Create a branch for local development:

    $ git checkout -b name-of-your-bugfix-or-feature

    Now you can make your changes locally.

  • Implement your changes and test them thoroughly

    # test code formating
make test

# test code logic
make unittest

# unit-test coverage
make coverage

# ensure your code passes pre-commit checks
make pre-commit

  • If all the tests above pass, your contribution is only one step to winning a review! Test the client against supported python versions!

    make multi

  • Commit your changes and push your branch to GitHub:

    git add .
git commit -m "Your detailed description of your changes."
git push origin name-of-your-bugfix-or-feature

  • Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.
  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.md.
  3. The pull request should work for Python 3.6, 3.7, 3.8 and 3.9.

Deploying

A reminder for the maintainers on how to deploy. Make sure all your changes are committed (including an entry in CHANGELOG.md). Then run:

```
poetry run bump2version patch # possible: major / minor / patch
git push
git push --tags
```

GitHub Actions will then deploy to PyPI if tests pass.