Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not highlight the opening @foreach and corresponding closing @endforeach #62

Open
glibgator opened this issue Nov 29, 2016 · 3 comments
Labels
atom-core The issue is dependent on Atom project or any of the first-party packages. enhancement Request for a new feature. help wanted The maintainers of package are welcoming pull requests that solve the issue.

Comments

@glibgator
Copy link

UI Theme - One Dark, Syntax Theme - Base16 Tomorrow Dark.

@Ingramz
Copy link
Collaborator

Ingramz commented Nov 29, 2016

@Sangramchahal I could not reproduce this.

Please provide additional information such as the snippet of code you are using, a screenshot of what you are seeing and the Atom version you are using.

@glibgator
Copy link
Author

Atom v1.12.6, language-blade v 0.26.2, Win10.
bladenon highlighting error
required highlighting

@Ingramz
Copy link
Collaborator

Ingramz commented Nov 29, 2016

@Sangramchahal I see what you mean now. The functionality you are looking for comes from atom/bracket-matcher package. Other than bracket characters, it also supports HTML and XML tag matching, but nothing else.

For example in PHP following the corresponding snippet would not work either:

foreach ($variable as $key => $value):
  $something = 10;
endforeach;

I'll leave this open for time being, but there is nothing I can do at the moment to solve this.

@Ingramz Ingramz added atom-core The issue is dependent on Atom project or any of the first-party packages. enhancement Request for a new feature. help wanted The maintainers of package are welcoming pull requests that solve the issue. labels Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atom-core The issue is dependent on Atom project or any of the first-party packages. enhancement Request for a new feature. help wanted The maintainers of package are welcoming pull requests that solve the issue.
Projects
None yet
Development

No branches or pull requests

2 participants