Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data from read_json functions could be stored as constants #68

Open
TomHall2020 opened this issue Feb 16, 2024 · 0 comments
Open

Data from read_json functions could be stored as constants #68

TomHall2020 opened this issue Feb 16, 2024 · 0 comments
Labels
Hacktoberfest Ideal issues for Hacktoberfest

Comments

@TomHall2020
Copy link
Contributor

I noticed during work on #67 that the read_json functions are called seperately in each AGB disciplines make_classification_dict function and stored to locals.

These could be called once and saved as constants, as any change to the data being loaded would require installing an updated version of archeryutils.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Ideal issues for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomHall2020 @jatkinson1000