From 9d0b8cce5fa14476b47577ec7b70b4e3fb34fbab Mon Sep 17 00:00:00 2001
From: Quan HL <quan.luuhoang8@gmail.com>
Date: Tue, 12 Dec 2023 14:11:02 +0700
Subject: [PATCH 1/3] wip

---
 src/api/types.ts                              |  1 +
 .../internal/views/carriers/form.tsx          | 21 +++++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/src/api/types.ts b/src/api/types.ts
index c91f6fcc..a3cc9ae9 100644
--- a/src/api/types.ts
+++ b/src/api/types.ts
@@ -482,6 +482,7 @@ export interface SipGateway extends Gateway {
   protocol?: string;
   port: number | null;
   pad_crypto?: boolean;
+  send_options_ping?: boolean;
 }
 
 export interface SmppGateway extends Gateway {
diff --git a/src/containers/internal/views/carriers/form.tsx b/src/containers/internal/views/carriers/form.tsx
index 06c0f5a1..b4671a52 100644
--- a/src/containers/internal/views/carriers/form.tsx
+++ b/src/containers/internal/views/carriers/form.tsx
@@ -1121,6 +1121,27 @@ export const CarrierForm = ({
                           </label>
                         </div>
                       )}
+                      <div>
+                        <label
+                          htmlFor={`send_options_ping_${i}`}
+                          className="chk"
+                        >
+                          <input
+                            id={`send_options_ping_${i}`}
+                            name={`send_options_ping_${i}`}
+                            type="checkbox"
+                            checked={g.send_options_ping ? true : false}
+                            onChange={(e) => {
+                              updateSipGateways(
+                                i,
+                                "send_options_ping",
+                                e.target.checked
+                              );
+                            }}
+                          />
+                          <div>Send Opts</div>
+                        </label>
+                      </div>
                     </div>
 
                     <button

From 04118d00603a535f5b389ba5de360240d1336494 Mon Sep 17 00:00:00 2001
From: Quan HL <quan.luuhoang8@gmail.com>
Date: Sat, 16 Dec 2023 16:34:40 +0700
Subject: [PATCH 2/3] up options ping

---
 .../internal/views/carriers/form.tsx          | 44 ++++++++++---------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/src/containers/internal/views/carriers/form.tsx b/src/containers/internal/views/carriers/form.tsx
index b4671a52..df9fbd8a 100644
--- a/src/containers/internal/views/carriers/form.tsx
+++ b/src/containers/internal/views/carriers/form.tsx
@@ -1121,27 +1121,29 @@ export const CarrierForm = ({
                           </label>
                         </div>
                       )}
-                      <div>
-                        <label
-                          htmlFor={`send_options_ping_${i}`}
-                          className="chk"
-                        >
-                          <input
-                            id={`send_options_ping_${i}`}
-                            name={`send_options_ping_${i}`}
-                            type="checkbox"
-                            checked={g.send_options_ping ? true : false}
-                            onChange={(e) => {
-                              updateSipGateways(
-                                i,
-                                "send_options_ping",
-                                e.target.checked
-                              );
-                            }}
-                          />
-                          <div>Send Opts</div>
-                        </label>
-                      </div>
+                      {Boolean(g.outbound) && (
+                        <div>
+                          <label
+                            htmlFor={`send_options_ping_${i}`}
+                            className="chk"
+                          >
+                            <input
+                              id={`send_options_ping_${i}`}
+                              name={`send_options_ping_${i}`}
+                              type="checkbox"
+                              checked={g.send_options_ping ? true : false}
+                              onChange={(e) => {
+                                updateSipGateways(
+                                  i,
+                                  "send_options_ping",
+                                  e.target.checked
+                                );
+                              }}
+                            />
+                            <div>Options ping</div>
+                          </label>
+                        </div>
+                      )}
                     </div>
 
                     <button

From 92a67610537de9c9dc0d00e9ac84152573e9eabb Mon Sep 17 00:00:00 2001
From: Quan HL <quan.luuhoang8@gmail.com>
Date: Mon, 15 Apr 2024 16:57:31 +0700
Subject: [PATCH 3/3] update review comments

---
 src/containers/internal/views/carriers/form.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/containers/internal/views/carriers/form.tsx b/src/containers/internal/views/carriers/form.tsx
index a2e26b66..afe66c16 100644
--- a/src/containers/internal/views/carriers/form.tsx
+++ b/src/containers/internal/views/carriers/form.tsx
@@ -1134,11 +1134,11 @@ export const CarrierForm = ({
                                 updateSipGateways(
                                   i,
                                   "send_options_ping",
-                                  e.target.checked
+                                  e.target.checked,
                                 );
                               }}
                             />
-                            <div>Options ping</div>
+                            <div>Send OPTIONS ping</div>
                           </label>
                         </div>
                       )}