Failed to load the line-diff-details package #45

mattdiamond · 2017-10-09T21:10:31Z

Atom: 1.21.0 x64
Electron: 1.6.9
OS: Mac OS X 10.12.6
Thrown From: line-diff-details package 1.9.0

Stack Trace

Failed to load the line-diff-details package

At ENOENT, node_modules/typescript/bin/lib.d.ts not found in /Applications/Atom.app/Contents/Resources/app.asar

Error: ENOENT, node_modules/typescript/bin/lib.d.ts not found in /Applications/Atom.app/Contents/Resources/app.asar
    at notFoundError (ELECTRON_ASAR.js:115:19)
    at Object.fs.readFileSync (ELECTRON_ASAR.js:514:9)
    at TypeScriptSimple.createService (/Applications/Atom.app/Contents/Resources/app/node_modules/typescript-simple/index.js:71:73)
    at TypeScriptSimple.compile (/Applications/Atom.app/Contents/Resources/app/node_modules/typescript-simple/index.js:60:43)
    at Object.exports.compile (/Applications/Atom.app/Contents/Resources/app/src/typescript.js:54:53)
    at Object.compile (/Applications/Atom.app/Contents/Resources/app/src/package-transpilation-registry.js:79:33)
    at compileFileAtPath (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:97:37)
    at Object.value [as .ts] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:238:26)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (/app.asar/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:903:35)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:158:34
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:99:21)
    at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app/src/package.js:144:18)
    at PackageManager.loadAvailablePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:617:16)
    at config.transact (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:530:20)
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app/src/config.js:342:22)
    at PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:528:23)
    at /Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:821:34

Commands

  8x -0:11.3.0 core:copy (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack)

Non-Core Packages

line-diff-details 1.9.0

The text was updated successfully, but these errors were encountered:

mattdiamond · 2017-10-10T15:32:39Z

Seeing something similar here:

smhxx/atom-ts-transpiler#8 (comment)

smhxx · 2017-10-12T23:35:06Z

I'm able to repro this on 1.21.0 as well. Haven't checked on previous versions, but from what we've deduced, this has to do with the built-in TypeScript support that Atom has, which utilizes typescript-simple =1.0.0, which in turn depends on typescript ~1.4.1. The location of the core library definitions was moved from bin/ to lib/ somewhere between TypeScript 1.4 and 1.5, which means that typescript-simple is unable to find the core library defs (lib.d.ts) when installed with the most recent version of TypeScript matching ~1.4.1. In other words, Atom's built-in TypeScript support is essentially broken, and when it sees lib/line-diff-details.ts, it tries to transpile it, but the definitions it needs aren't where it expects them, and boom, error.

There are probably a few equally-valid ways of fixing this:

Switch lib/line-diff-details.ts from TypeScript to JavaScript, optionally with a "use babel"; directive to enable newer JavaScript features
Compile the TypeScript prior to publishing with apm, and set the "main" file in package.json to the compiled JavaScript output
Continue to publish the package in TypeScript, but specify a custom transpiler to handle the TS->JS conversion on install/first run by the user (full disclosure: The only one of these that currently exists for TypeScript is the one I wrote, which @mattdiamond linked above, available as atom-ts-transpiler on npm.)

Just as a fore-warning if you decide to go with the third approach, atom-ts-transpiler is theoretically stable, but still very new, and I'm currently working on getting it field-tested with the help of a few collaborators. As I've dealt with this problem before, (hence writing a package to work around the issue,) I'm around to help out if you need any assistance. 😃

smhxx · 2017-10-13T01:53:34Z

(btw, I've just checked and confirmed that line-diff-details does load and run with no issues using atom-ts-transpiler 1.2.0 and typescript 2.5.3, if that's a route you end up wanting to go) 👍 It's probably overkill for such a small package, and could be easier resolved by just switching the main file from .ts to .js or .coffee, but like I said, it's one of several options.

robiXxu · 2017-10-13T08:44:36Z

Also in Windows 10.

exside · 2017-10-16T11:27:21Z

+1

mattdiamond · 2017-10-16T14:47:50Z

In other words, Atom's built-in TypeScript support is essentially broken

Is there an open issue or pull request to resolve this?

smhxx · 2017-10-16T19:38:31Z

I'm not aware of one, but I haven't checked. It's a pretty simple fix since the bug is just due to a backwards-incompatible change being pushed out in a patch version instead of a major version (although I don't think the TypeScript maintainers realized that typescript-simple was relying directly on the lib.d.ts file, so they wouldn't have known moving it would break anything.)

I think it should just require bumping Atom's dependency on typescript-simple from 1.0.0 (which is now broken) to any version that uses TypeScript 1.5 or later. It should probably not be 2.x, though, since that has the potential to leave some packages already using TS just as broken as they were before.

mberrueta · 2017-11-29T12:42:25Z

+1

Atom: 1.22.1
Atom-Shell:
OS: Mac OS X 10.13.1
Misc
- apm 1.18.8
- npm 3.10.10
- node 6.9.5 x64
- python 2.7.10
- git 2.13.6

smhxx · 2017-11-30T05:53:06Z

Since this problem appears to be ongoing, I suppose it's worth mentioning the official response from one of the Atom devs at atom/atom#15909 (thanks to @mattdiamond for opening that issue)

capaj · 2018-02-02T10:18:58Z

@smhxx I just ran into this bug this morning. It sure would be nice to get this fixed.

I am on ubuntu 17.10 atom 1.23.3 x64

cdbattags · 2018-02-06T15:47:05Z

This still ain't fixed? 😜

What can I do to help? Are we waiting on another repo to get updated? Can we enact a temp fix and repair back to the proper Atom way when the dep lib gets patched?

grizzlydotweb · 2018-03-20T14:53:23Z

hoping for some good news soon. Exactly the package i was lookng for, but during install I end up here. 🙈

smhxx · 2018-03-20T15:35:22Z

There is a PR open which fixes this bug (#46) but it has changes requested and the author has not updated it yet. If needed, I can open a separate PR so that we can get this package working again, as it's been quite a while and it seems that several people are waiting for it to be fixed.

This patch adds atom-ts-transpiler and TypeScript as dependenies, circumventing the issues that have been occuring in recent versions of Atom where TypeScript source files would fail to be loaded. Closes jakesankey#45, jakesankey#46.

emanuelegissi · 2018-06-08T12:52:02Z

Replacing line-diff-details with line-diff-details-plus solves the problem.

mattdiamond mentioned this issue Oct 16, 2017

Typescript transpilation is "essentially broken" due to change in location of core library definitions atom/atom#15909

Closed

jbazin30 mentioned this issue Nov 14, 2017

Fix failed to load package #46

Open

smhxx mentioned this issue Mar 20, 2018

Add custom transpiler to fix 'failed to load package' issue #47

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Failed to load the line-diff-details package #45

Failed to load the line-diff-details package #45

mattdiamond commented Oct 9, 2017

mattdiamond commented Oct 10, 2017

smhxx commented Oct 12, 2017 •

edited

Loading

smhxx commented Oct 13, 2017 •

edited

Loading

robiXxu commented Oct 13, 2017

exside commented Oct 16, 2017

mattdiamond commented Oct 16, 2017

smhxx commented Oct 16, 2017 •

edited

Loading

mberrueta commented Nov 29, 2017

smhxx commented Nov 30, 2017

capaj commented Feb 2, 2018

cdbattags commented Feb 6, 2018

grizzlydotweb commented Mar 20, 2018

smhxx commented Mar 20, 2018 •

edited

Loading

emanuelegissi commented Jun 8, 2018

Failed to load the line-diff-details package #45

Failed to load the line-diff-details package #45

Comments

mattdiamond commented Oct 9, 2017

Stack Trace

Commands

Non-Core Packages

mattdiamond commented Oct 10, 2017

smhxx commented Oct 12, 2017 • edited Loading

smhxx commented Oct 13, 2017 • edited Loading

robiXxu commented Oct 13, 2017

exside commented Oct 16, 2017

mattdiamond commented Oct 16, 2017

smhxx commented Oct 16, 2017 • edited Loading

mberrueta commented Nov 29, 2017

smhxx commented Nov 30, 2017

capaj commented Feb 2, 2018

cdbattags commented Feb 6, 2018

grizzlydotweb commented Mar 20, 2018

smhxx commented Mar 20, 2018 • edited Loading

emanuelegissi commented Jun 8, 2018

smhxx commented Oct 12, 2017 •

edited

Loading

smhxx commented Oct 13, 2017 •

edited

Loading

smhxx commented Oct 16, 2017 •

edited

Loading

smhxx commented Mar 20, 2018 •

edited

Loading