Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform label frustum from LabelGrid.getLabelsToDisplay rather than from Sigma.renderLabels directly #1309

Open
Yomguithereal opened this issue Nov 9, 2022 · 2 comments

Comments

@Yomguithereal
Copy link
Collaborator

Yomguithereal commented Nov 9, 2022

This means we could avoid linearly checking all the label candidates present from the grid since we know how to filter out some grid cells altogether when they are outside of the viewed rectangle. However it is also possible this does not yield any empirical advantage so we must 1. gather some runtime data before and 2. benchmark.

Note: performing frustum when populating the grid is probably not a good idea because it would require to do it on each render and makes indexation dependent on camera state which is not ideal.

@stale
Copy link

stale bot commented Dec 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 19, 2022
@stale
Copy link

stale bot commented Jan 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 29, 2023
@sim51 sim51 added pinned and removed wontfix labels Jan 29, 2023
@Yomguithereal Yomguithereal changed the title Label grid frustum Perform label frustum from LabelGrid.getLabelsToDisplay rather than from Sigma.renderLabels directly Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants