Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.boot fixture out of date, causing a test failure #68

Open
Yhprum opened this issue May 13, 2022 · 1 comment
Open

Client.boot fixture out of date, causing a test failure #68

Yhprum opened this issue May 13, 2022 · 1 comment

Comments

@Yhprum
Copy link
Contributor

Yhprum commented May 13, 2022

/spec/fixtures/clientBoot.json is a bit outdated - namely, the prefs object has been moved out of the self object and is now a key in the base object (this is what is causing the error right now). My own client.boot output seems to be 1168 lines compared to the 633 in the fixture, idk if you omitted anything though.

Solutions could be to just move the offending prefs object to it's rightful place, or to just grab the new client.boot (though it would be a bit time consuming to sanitize all my personal info out of it tbh). What do you think?

@jackellenberger
Copy link
Owner

yeah, i think unfortunately the client boot fixture is a bit hand crafted at the moment. If memory service I pulled down a live one, then got tired sanitizing it 😬 I think making a minimal one that satisfies the tests (and of course updating the tests to expect real life content) would be a good move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants