Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Allow bursting for rate limited requests #56

Open
jackellenberger opened this issue Sep 3, 2020 · 0 comments
Open

[Improvement] Allow bursting for rate limited requests #56

jackellenberger opened this issue Sep 3, 2020 · 0 comments

Comments

@jackellenberger
Copy link
Owner

jackellenberger commented Sep 3, 2020

For operations like downloading the initial emojilist, if you have more than 50 pages of emoji (and we do), then the minimum download time is SLACK_REQUEST_WINDOW = 60000ms. That's kind of a nasty user experience, esp because slack does allow bursting. We could get our 53 pages in no time at all by just running emojme with the SLACK_REQUEST_RATE set to 60, but that will override other rate limited endpoints to use that rate, which may fail in a sync type scenario.

If we just build in bursting, mayyyybe that'd make the problem easier. the implementation I imagine is just "go as fast as possible until we get rate limited, then abide by the limit." shrug_intensifies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant