Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why Ant projects no longer have jME icon #465

Open
tonihele opened this issue Feb 4, 2023 · 3 comments
Open

Investigate why Ant projects no longer have jME icon #465

tonihele opened this issue Feb 4, 2023 · 3 comments

Comments

@tonihele
Copy link
Contributor

tonihele commented Feb 4, 2023

Investigate why Ant projects no longer have jME icon. Some regression. But it also might have some relation to https://hub.jmonkeyengine.org/t/convert-scene-to-3jo-using-sdk/46417/8. Should be checked...

@tonihele
Copy link
Contributor Author

tonihele commented Feb 4, 2023

Or.. is the forum issue because of #264?
https://wiki.jmonkeyengine.org/docs/3.4/tutorials/beginner/hello_asset.html

@neph1
Copy link
Contributor

neph1 commented Feb 11, 2023

Could be related to replacing icons.
Edit: Also: Do we want the icon for gradle projects?
Edit2: I did a search for the old logo and it didn't turn up anything. I tried replacing the new logo with a png, but that didn't do anything either. CodelessProject files in general seem unchanged by icon replacement

@peedeeboy
Copy link
Contributor

We should investigate the feasibility of a big refactor...

At the moment, most SDK functionality seems to hang off the Assets Node, which gets created if a project contains /assets folder. Basically, following this tutorial: https://netbeans.apache.org/tutorial/main/tutorials/nbm-projectextension/

We should consider using the Netbeans Projects API to create JME Ant Project, JME Gradle Project etc - we essentially want our own projects to be a sub-type of the stanard Java Ant and Gradle projects. Not sure how easy / feasible this is with the Netbeans Project API 🤔

The projects could (hopefully) be configured such that a project is recognised as a JME Ant project is the root folder contains a build.xml & has the JME core library on the classpath?

Then we could override icons etc for our custom project sub-type. E.g. a jMonkeyEngine Gradle project could use the jMonkeyEngine Jamie head as the main icon, with the Gradle elephant as the little sub-icon in the corner 👍

We would need to do a pretty big refactor of splitting classes that currently have Gradle and Ant functionality (e.g. the SDK Asset Manager class) into Interfaces, then write implementations for Ant and Gradle projects, which go into the Project's lookups at creation time.....

But this would make things more maintainable in the long run, and open up the possibility of implementing Maven project support....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants