Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor teams-skills and team-skill #134

Open
RamiSouai opened this issue Jul 25, 2022 · 0 comments
Open

Refactor teams-skills and team-skill #134

RamiSouai opened this issue Jul 25, 2022 · 0 comments
Labels
frontend technical-dept Quick solution that needs to be refactored at a later point in time

Comments

@RamiSouai
Copy link
Contributor

RamiSouai commented Jul 25, 2022 •
edited
Loading

The components teams-skills and team-skill have caused a lot of confusion during development. Both are lists of skills, we should either merge these two components or at least rename them.

teams-skills: The list of skills in a team's living room.
team-skill: The general skill-list, regardless of team.

A possible solution would be to create a skill-list component that accepts a team as an Input, and if that input is null then show the team-skill, else show the teams-skills
@RamiSouai RamiSouai added bug Something isn't working frontend technical-dept Quick solution that needs to be refactored at a later point in time and removed bug Something isn't working labels Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend technical-dept Quick solution that needs to be refactored at a later point in time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RamiSouai