Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return not_implemented for options that have not been implemented that can't blindly be ignored. #95

Open
JustinKyleJames opened this issue Feb 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JustinKyleJames
Copy link
Contributor

There are many options for the supported API's that we don't currently support. Depending on the context, some can be ignored while others should not be blindly ignored.

For the latter, we should return the not_implemented HTTP response.

An example of the former could be versionId on DeleteObject. Since we don't support versions, it might make sense to just continue with the deletion.

An example of the latter might be If-Modified-Since on GetObject.

These are judgement calls. In this issue we will go through each option and decide which of the two fit and implement them. This will not be in 0.2.0.

@JustinKyleJames JustinKyleJames added the enhancement New feature or request label Feb 16, 2024
@JustinKyleJames JustinKyleJames self-assigned this Feb 16, 2024
@korydraughn korydraughn added this to the 0.2.0 milestone Feb 16, 2024
@alanking
Copy link

This will not be in 0.2.0.

Should we make a new milestone so that this does have a home?

@trel
Copy link
Member

trel commented Feb 16, 2024

sure - 0.3.0 here we come.

@alanking alanking modified the milestones: 0.2.0, 0.3.0 Feb 16, 2024
@alanking
Copy link

We did it. Feel free to... undo that. :)

@trel trel modified the milestones: 0.3.0, 0.4.0 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants