Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put multipart_global_state variables in their own source file and put the extern declarations in a header. #131

Open
JustinKyleJames opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@JustinKyleJames
Copy link
Contributor

JustinKyleJames commented Oct 4, 2024

Right now the multipart_global_state variables are defined in putobject.cpp and the other files that use these each have their own extern declarations for them.

Reorganize this to put these variables in their own file/compilation unit and update s3_api.hpp to include the extern declarations.

Also change the part_shmem alias used to mpart_global_state so it more accurately reflects the code.

@JustinKyleJames JustinKyleJames self-assigned this Oct 4, 2024
@korydraughn korydraughn added this to the 0.4.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants