Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing postinst script #138

Closed
korydraughn opened this issue Feb 21, 2024 · 2 comments
Closed

Add missing postinst script #138

korydraughn opened this issue Feb 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@korydraughn
Copy link
Contributor

Bug Report

The following lines ...

set(CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA "${CMAKE_SOURCE_DIR}/packaging/postinst;")
set(CPACK_RPM_POST_INSTALL_SCRIPT_FILE "${CMAKE_SOURCE_DIR}/packaging/postinst")

lead to the following output because the postinst script does not exist.

CPack Warning: Adding file to tar:                                                                                                                                                            
#top level directory: /home/kory/dev/github/irods_capability_indexing_build/_CPack_Packages/Linux/DEB/irods_capability-indexing-4.3.1.0-Linux/document-type                                   
#missing file: /home/kory/dev/github/irods_capability_indexing/packaging/postinst              
CPack Warning: Adding file to tar:                                                             
#top level directory: /home/kory/dev/github/irods_capability_indexing_build/_CPack_Packages/Linux/DEB/irods_capability-indexing-4.3.1.0-Linux/elasticsearch
#missing file: /home/kory/dev/github/irods_capability_indexing/packaging/postinst

Considering other iRODS repos contain that script, we should add it.

@korydraughn korydraughn added the bug Something isn't working label Feb 21, 2024
@korydraughn korydraughn added this to the 4.3.1.0 milestone Feb 21, 2024
@korydraughn korydraughn self-assigned this Feb 21, 2024
@korydraughn
Copy link
Contributor Author

The references to the postinst script are not needed and should be removed.

See #131 (comment).

@korydraughn
Copy link
Contributor Author

Related to #108.

korydraughn added a commit to korydraughn/irods_capability_indexing that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant