Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on PRC for tests #101

Open
d-w-moore opened this issue Apr 7, 2022 · 0 comments
Open

Dependency on PRC for tests #101

d-w-moore opened this issue Apr 7, 2022 · 0 comments
Milestone

Comments

@d-w-moore
Copy link
Contributor

First, this change will introduce a dependency on PRC, which is currently unprecedented. Personally, I don't think we want that.

HOWEVER, I have learned very recently that no mechanism currently exists which will trigger the atomic API PEPs. So seeing as how this is the only way to do this in existence, I think we can let it pass for now.

We need to do one of two things:

  1. The test hook needs to install PRC in order for the tests to run
  2. We add a unittest.skip decorator to this test with a note about how it can only run on systems with PRC available and is only being run manually at this time?

Let's make an issue for when the magical new imeta option appears :)

Originally posted by @alanking in #95 (comment)

@d-w-moore d-w-moore changed the title First, this change will introduce a dependency on PRC, which is currently unprecedented. Personally, I don't think we want that. Dependency on PRC for tests Apr 7, 2022
@korydraughn korydraughn added this to the 4.3.2.1 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants