Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call which program from Python #252

Open
SwooshyCueb opened this issue Jun 10, 2024 · 0 comments
Open

Do not call which program from Python #252

SwooshyCueb opened this issue Jun 10, 2024 · 0 comments
Assignees
@SwooshyCueb

Comments

@SwooshyCueb
Copy link
Member

In build.py we make a call to the external program which.

externals/build.py

Line 484 in 1b220bc

run_cmd(['which', fpmbinary], check_rc='fpm not found, try "gem install fpm"')

This adds a dependency that has multiple incompatible implementations. Let's use shutil.which instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SwooshyCueb SwooshyCueb

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SwooshyCueb