[TKW] Add MinimumOp as an op for Quantized LLM and GenAI workload #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raikonenfnu Can you tell me why the CI may be failing? Does not seem related to the changes I did. Edit: I rebased because I think the CI was failing due to and was fixed in #347 |
The tkw.minimum(elementwise) is lowered into arith::MinimumFOp, arith::MinisIOp, and arith::MiniuIOp for floats, signed and unsigned integers respectively Signed-off-by: nouman-10x <[email protected]>
Signed-off-by: nouman-10x <[email protected]>
|
@NoumanAmir657 Our e2e runner can runs weird sometimes, we are looking into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tkw.minimum(elementwise) is lowered into arith::MinimumFOp, arith::MinisIOp, and arith::MiniuIOp for floats, signed and unsigned integers respectively
Fixes: #339