Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance degradation between 0.13 and 0.14 #156

Open
rkuhn opened this issue Oct 21, 2022 · 0 comments
Open

performance degradation between 0.13 and 0.14 #156

rkuhn opened this issue Oct 21, 2022 · 0 comments

Comments

@rkuhn
Copy link

rkuhn commented Oct 21, 2022

ipfs-rust/unixfsv1@6453d9b introduced a ca. 10% slowdown in the unixfs-v1 benchmarks (I first ran the new, then the old):

adder/175               time:   [51.599 us 51.613 us 51.630 us]                     
                        thrpt:  [3.2325 MiB/s 3.2335 MiB/s 3.2344 MiB/s]
                 change:
                        time:   [-0.2399% -0.1194% -0.0202%] (p = 0.03 < 0.05)
                        thrpt:  [+0.0202% +0.1195% +0.2405%]
                        Change within noise threshold.
Found 3 outliers among 30 measurements (10.00%)
  2 (6.67%) high mild
  1 (3.33%) high severe
adder/30277             time:   [9.2331 ms 9.2395 ms 9.2469 ms]                       
                        thrpt:  [3.1226 MiB/s 3.1251 MiB/s 3.1273 MiB/s]
                 change:
                        time:   [-7.2410% -7.1500% -7.0590%] (p = 0.00 < 0.05)
                        thrpt:  [+7.5951% +7.7006% +7.8063%]
                        Performance has improved.
Found 1 outliers among 30 measurements (3.33%)
  1 (3.33%) high mild
adder/60553             time:   [22.040 ms 22.051 ms 22.061 ms]                       
                        thrpt:  [2.6176 MiB/s 2.6189 MiB/s 2.6201 MiB/s]
                 change:
                        time:   [-9.5500% -9.4965% -9.4400%] (p = 0.00 < 0.05)
                        thrpt:  [+10.424% +10.493% +10.558%]
                        Performance has improved.

Haven’t looked further yet (need to finish a larger upgrade first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant