Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized implementations of References for DagPbCodec and DagJsonCodec #154

Open
rklaehn opened this issue Oct 6, 2022 · 0 comments
Open

Comments

@rklaehn
Copy link
Contributor

rklaehn commented Oct 6, 2022

Currently, DagCbor References scrapes references from a blob very efficiently. But DagPbCodec and DagJsonCodec does not. It creates a temporary IPLD AST just to scrape the links from that and throw away the rest.

Especially for DagPbCodec this should be easy, since links are all in one part.

// An IPFS MerkleDAG Node
message PBNode {
  // refs to other objects
  repeated PBLink Links = 2;
  // opaque user data
  bytes Data = 1;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant