Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minechem-1.7.10-5.0.5.406 and BetterBuildersWands crash #823

Open
SvEgiiVEteR opened this issue May 8, 2016 · 10 comments
Open

Minechem-1.7.10-5.0.5.406 and BetterBuildersWands crash #823

SvEgiiVEteR opened this issue May 8, 2016 · 10 comments

Comments

@SvEgiiVEteR
Copy link

https://gist.github.com/53a980289df01ffefbb75e4b650f1d5a
Minechem-1.7.10-5.0.5.406
Better Builder's Wands 0.6.0 [MC1.7.10; rev 78]
not compatible mods
and full log
https://gist.github.com/6f92dad414579c6134e5c787d2a01863
how can I fix this? or any one of the authors?

@portablejim
Copy link

The proper fix is for minechem to not assume Lists are java.util.ArrayLists . Instead use the List interface, as per ShapelessRecipe.

@SvEgiiVEteR
Copy link
Author

@portablejim the mod have not been updated. probably the author won't fix it...

@Luaancz
Copy link

Luaancz commented May 29, 2016

I've just rebuilt the project with latest Forge, and everything works fine with BetterBuildersWands - too bad the latest official build still fails :) The latest code isn't quite... production ready, though.

EDIT: I've made a fix for 5.0.5 as well, you can take it from my fork or wait for the pull request to go through (which may or may not happen, ever :)).

@SvEgiiVEteR
Copy link
Author

BetterBuildersWands-0.8.0-1.7.10r89+339bc1f.jar
the conflict remained (((
very bad((

@jakimfett
Copy link
Collaborator

Oi, @Luaancz, I don't see a pull request from you...?

@Luaancz
Copy link

Luaancz commented Dec 18, 2016

@jakimfett Actually, you've already merged it in on May 31th for 5.0.5; I didn't make a pull request for the 6, that was really just updating Forge version.

@Wealthyturtle
Copy link

#823

Still Crashes

@Jonius7
Copy link

Jonius7 commented Sep 13, 2020

@jakimfett Actually, you've already merged it in on May 31th for 5.0.5; I didn't make a pull request for the 6, that was really just updating Forge version.

Noticing this, I rebuilt the latest commit of master on my fork, confirmed to be working with BetterBuildersWands. This includes a bunch of unreleased changes - changes that were not included in the 5.0.5.406 version that was on Curseforge

@jakimfett
Copy link
Collaborator

@Jonius7 does #853 fix the issue mentioned regarding Lists?

ref:

portablejim commented on May 8, 2016
The proper fix is for minechem to not assume Lists are java.util.ArrayLists . Instead use the List interface, as per ShapelessRecipe.

@Jonius7
Copy link

Jonius7 commented Dec 5, 2020

I didn't change anything regarding that, so if it was fixed already, it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants