Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Adapter license icon #2755

Open
2 of 3 tasks
Jey-Cee opened this issue Oct 8, 2024 · 4 comments
Open
2 of 3 tasks

[bug]: Adapter license icon #2755

Jey-Cee opened this issue Oct 8, 2024 · 4 comments

Comments

@Jey-Cee
Copy link
Contributor

Jey-Cee commented Oct 8, 2024

No existing issues.

  • There is no existing issue for my problem.

Describe the bug

There is some confusion about the license icon and where it is linking.
In the io-package.json the licenseInformation has a link field. It was told that this has to be the URL to the commercial license or the information about.

But when the icon is clicked it links to the source code license.
This also happens if the icon is invisible while it is a non paid adapter.

There is no difference between card or list view.

"licenseInformation": { "license": "CC-BY-NC-4.0", "type": "paid", "link": "https://www.all-smart.net/produkt/iobroker-net-tools-v1-lizenz/" },

To Reproduce

Click the license icon on any adapter in the adapter list.

Expected behavior

  • Icon should link to the commercial license information.

  • The icon should not be clickable if it is not visible and use no space.

Screenshots & Logfiles

grafik

Adapter version

7.2.2

js-controller version

6.0.11

Node version

20.17.0

Operating system

Ubuntu

Additional context

FireFox and Chrome on Desktop

@Jey-Cee Jey-Cee added the bug label Oct 8, 2024
@mcm1957
Copy link
Contributor

mcm1957 commented Oct 9, 2024

The icon should not be clickable if it is not visible and use no space.

OK for tile view

For LIST view the space for the icon MUST be kept empty as all symbols should be displayed one below the other:
image
So the sentry symbol should NOT shift to the left if no license symbol is displayed.

@mattreim
Copy link

mattreim commented Oct 9, 2024

Isn't it more advisable to move the less used symbol to the back? And @Jey-Cee is right it is selectable even though it is hidden.

IOB_List

@mattreim
Copy link

With 7.2.5 it looks much better and it is no longer selectable. Thanks

@Jey-Cee
Copy link
Contributor Author

Jey-Cee commented Oct 10, 2024

Checked it and can also confirm.
Still the link isn't pointing to the correct location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants