-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Adapter license icon #2755
Comments
Isn't it more advisable to move the less used symbol to the back? And @Jey-Cee is right it is selectable even though it is hidden. |
GermanBluefox
added a commit
that referenced
this issue
Oct 10, 2024
With 7.2.5 it looks much better and it is no longer selectable. Thanks |
Checked it and can also confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No existing issues.
Describe the bug
There is some confusion about the license icon and where it is linking.
In the io-package.json the licenseInformation has a link field. It was told that this has to be the URL to the commercial license or the information about.
But when the icon is clicked it links to the source code license.
This also happens if the icon is invisible while it is a non paid adapter.
There is no difference between card or list view.
"licenseInformation": { "license": "CC-BY-NC-4.0", "type": "paid", "link": "https://www.all-smart.net/produkt/iobroker-net-tools-v1-lizenz/" },
To Reproduce
Click the license icon on any adapter in the adapter list.
Expected behavior
Icon should link to the commercial license information.
The icon should not be clickable if it is not visible and use no space.
Screenshots & Logfiles
Adapter version
7.2.2
js-controller version
6.0.11
Node version
20.17.0
Operating system
Ubuntu
Additional context
FireFox and Chrome on Desktop
The text was updated successfully, but these errors were encountered: