Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Branch constructors #21

Open
raphaelsaavedra opened this issue Jul 21, 2022 · 0 comments
Open

Review Branch constructors #21

raphaelsaavedra opened this issue Jul 21, 2022 · 0 comments
Labels
idea Needs discussion to decide what if anything to do

Comments

@raphaelsaavedra
Copy link
Member

We have several ways of constructing Branch. It's unclear if some of the fields should really have default values (resistance, reactance for example should probably not have defaults) and what the best constructors should be in practice. We should review the current defined methods and what we think it's best for us.
@raphaelsaavedra raphaelsaavedra mentioned this issue Jul 21, 2022
Merged
@nickrobinson251 nickrobinson251 added the idea Needs discussion to decide what if anything to do label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea Needs discussion to decide what if anything to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickrobinson251 @raphaelsaavedra