Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: links in ad-hoc queries #906

Open
cportele opened this issue Feb 15, 2023 · 1 comment
Open

Search: links in ad-hoc queries #906

cportele opened this issue Feb 15, 2023 · 1 comment
Assignees
Milestone

Comments

@cportele
Copy link
Member

A follow-up to #755: Properly handle links in responses to ad-hoc queries (links imply use of GET, but ad-hoc queries use POST with JSON payload). The currently links are not correct.

The self and alternate links should simply be suppressed, there is no resource on the server that we can link to (this is a transient ad-hoc query).

With respect to the next link, if there are more matches than the page size, here are some options:

  • No support paging with ad-hoc queries.
  • Use an extended link object that includes the information to use the POST method and includes the request content and content type. The content is the same as from the request - with an adjusted value for offset.
  • Store that request for a few minutes and use a hash key to create an opaque next link.

The first option is not a good idea, paging should be supported for all requests that deliver features.

The third option also will not work, if the deployment consists of multiple instances, the next-queries would need to be stored in a shared store.

The second option is not ideal either, but probably the best approach and could be useful in other cases, too. The approach should also be discussed in OGC (maybe just remove the links for now and wait for that discussion). There is also a somewhat related I-D.

@cportele cportele added the bug label Feb 15, 2023
@cportele cportele added this to the v3.4.0 milestone Feb 15, 2023
@cportele cportele self-assigned this Feb 15, 2023
cportele added a commit that referenced this issue May 2, 2023
This is a first step to address #906. The self, alternate and paging links are removed for ad-hoc queries.

The limitation that ad-hoc queries do not support paging has been documented as a limitation in the building block for now until this issue has been discussed in OGC. For now, use sufficiently large values for the limit parameter to avoid the need for paging.
@cportele cportele modified the milestones: v3.4.0, v4.x.0 May 2, 2023
@cportele
Copy link
Member Author

cportele commented May 2, 2023

PR #958 addresses the bug (incorrect links) by removing the links and documents the limitation.

How to handle paging links in responses to ad-hoc queries should be first discussed in OGC. The issue will be placed in the backlog until then.

@cportele cportele modified the milestones: v4.x.0, v3.5.0 May 2, 2023
cportele added a commit that referenced this issue May 2, 2023
This is a first step to address #906. The self, alternate and paging links are removed for ad-hoc queries.

The limitation that ad-hoc queries do not support paging has been documented as a limitation in the building block for now until this issue has been discussed in OGC. For now, use sufficiently large values for the limit parameter to avoid the need for paging.
@cportele cportele modified the milestones: v3.5.0, v4.0.0 Aug 9, 2023
@cportele cportele modified the milestones: v4.0.0, v4.x.0 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant