Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Successful containers should not overwrite Failed phase set by former containers #303

Open
landerlini opened this issue Oct 17, 2024 · 0 comments
Open

Successful containers should not overwrite Failed phase set by former containers #303

landerlini opened this issue Oct 17, 2024 · 0 comments
Assignees
@Bianco95
Labels
bug Something isn't working v0.3.x
Milestone
0.3.x

Comments

@landerlini
Copy link

landerlini commented Oct 17, 2024 •
edited
Loading

interLink/pkg/virtualkubelet/execute.go

Lines 615 to 618 in dc9f75b

case podCompleted && podRefInCluster.Status.Phase != v1.PodSucceeded:
podRefInCluster.Status.Conditions = append(podRefInCluster.Status.Conditions, v1.PodCondition{Type: v1.PodReady, Status: v1.ConditionFalse})
podRefInCluster.Status.Phase = v1.PodSucceeded
podRefInCluster.Status.Reason = "Completed"

In multicontainer pods, if a container fails, the pod phase should be set to "Failed".

Instead, the last container in the container status is granted the right to revert a "Failed" status to "Succeeded".
landerlini pushed a commit to landerlini/interlink-condorce-plugin that referenced this issue Oct 17, 2024
Swap init_container and container statuses to workaround interTwin-eu…
b9a0161 
…/interLink#303
@dciangot dciangot added the bug Something isn't working label Nov 12, 2024
@dciangot dciangot added this to the 0.4.x milestone Nov 12, 2024
@dciangot dciangot self-assigned this Nov 12, 2024
@dciangot dciangot modified the milestones: 0.4.x, 0.3.x Dec 13, 2024
@dciangot dciangot assigned Bianco95 and unassigned dciangot Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bianco95 Bianco95

Labels
bug Something isn't working v0.3.x
Projects
None yet
Milestone
0.3.x
Development

When branches are created from issues, their pull requests are automatically linked.

303-successful-containers-should-not-overwrite-failed-phase-set-by-former-containers interTwin-eu/interLink
3 participants
@dciangot @Bianco95 @landerlini