diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 7321751..4c6adb4 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -7,7 +7,7 @@ jobs: close-issues: runs-on: ubuntu-latest steps: - - uses: actions/stale@v3 + - uses: actions/stale@v4.0.0 with: days-before-issue-stale: 90 days-before-issue-close: 14 diff --git a/README.md b/README.md index 9bc6b68..c590532 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,7 @@ Changelog is available [here](https://github.com/insideapp-oss/sonar-flutter/blo ### Flutter SDK -Install Flutter as explained on the official documentaiton page. +Install Flutter as explained on the official documentation page. [Installation instructions](https://flutter.dev/docs/get-started/install) @@ -40,7 +40,7 @@ Install Flutter as explained on the official documentaiton page. Dart is downloaded by the Flutter SDK in **$FLUTTER_HOME/bin/cache/dart-sdk**, however command lines are not on the path by default (dartanalyzer must be on the path). -It is recommanded to install Dart SDK separately as explained here : [Install the Dart SDK](https://dart.dev/get-dart) for more reliability in a CI/CD environement. +It is recommended to install Dart SDK separately as explained here : [Install the Dart SDK](https://dart.dev/get-dart) for more reliability in a CI/CD environment. ### sonar-scanner (requires Java) diff --git a/dart-lang/pom.xml b/dart-lang/pom.xml index 9307f67..ac9756b 100644 --- a/dart-lang/pom.xml +++ b/dart-lang/pom.xml @@ -3,7 +3,7 @@ sonar-flutter fr.insideapp.sonarqube - 0.3.2 + 0.4.0 4.0.0 diff --git a/pom.xml b/pom.xml index 1899b0a..27ccd2a 100644 --- a/pom.xml +++ b/pom.xml @@ -5,12 +5,12 @@ org.sonarsource.parent parent - 52 + 59.0.29 fr.insideapp.sonarqube sonar-flutter - 0.3.2 + 0.4.0 pom @@ -31,7 +31,7 @@ GNU LGPL 3 - http://www.gnu.org/licenses/lgpl.txt + https://www.gnu.org/licenses/lgpl-3.0.txt repo @@ -58,8 +58,6 @@ true - 6.7 - 3.5.2 17.0 4.10 @@ -70,7 +68,7 @@ 3.22.0.1791 4.0.0.2052 1.23 - 2.6.1 + 2.7.1.392 1.6 1.10.2.456 3.5.2 diff --git a/scripts/updateDartAnalyzerRules.groovy b/scripts/updateDartAnalyzerRules.groovy index c640248..ba8974b 100644 --- a/scripts/updateDartAnalyzerRules.groovy +++ b/scripts/updateDartAnalyzerRules.groovy @@ -82,7 +82,12 @@ def assignType(key) { } if (grandParentNode.name.text() == 'Reliability') { - return "BUG" + + // See https://github.com/insideapp-oss/sonar-flutter/pull/32 + if (!ruleNode.name.text().startsWith('prefer_final')) { + return "BUG" + } + } } diff --git a/sonar-flutter-plugin/pom.xml b/sonar-flutter-plugin/pom.xml index 36a912a..fb06b3f 100644 --- a/sonar-flutter-plugin/pom.xml +++ b/sonar-flutter-plugin/pom.xml @@ -4,7 +4,7 @@ sonar-flutter fr.insideapp.sonarqube - 0.3.2 + 0.4.0 4.0.0 @@ -17,7 +17,7 @@ fr.insideapp.sonarqube dart-lang - 0.3.2 + 0.4.0