Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ [TASK] : Convert Spelling check to a standard check targets. #115

Closed
stevenj opened this issue Dec 1, 2023 · 0 comments · Fixed by #118
Closed

🛠️ [TASK] : Convert Spelling check to a standard check targets. #115

stevenj opened this issue Dec 1, 2023 · 0 comments · Fixed by #118
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stevenj
Copy link
Collaborator

stevenj commented Dec 1, 2023

Summary

Make spelling check conform to check target pattern

Description

Currently Spelling checks are independent of our standard CI pipeline.

We still need the ability to efficiently run the check locally.

But in CI we can use a standard check target for these and then remove the github action which is triggering these.

This will help better align our CI pipeline and reduce the number of github actions we need to enforce.

We would also need to add Spelling guide, which is be a part of this ticket.
This ticket also includes updating both:
https://github.com/input-output-hk/catalyst-voices
https://github.com/input-output-hk/hermes

To use the update check target, each will need a new issue raised to track this issue, and for the PR in those repos to be raised against that Issue.

@stevenj stevenj moved this to 🆕 New in Catalyst Dec 1, 2023
@stevenj stevenj added enhancement New feature or request good first issue Good for newcomers labels Dec 1, 2023
@apskhem apskhem linked a pull request Dec 1, 2023 that will close this issue
8 tasks
@Mr-Leshiy Mr-Leshiy moved this from 🆕 New to 🏗 In progress in Catalyst Dec 5, 2023
@Mr-Leshiy Mr-Leshiy moved this from 🏗 In progress to ✅ Done in Catalyst Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants