Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous warning when elevation is equal to 90 degrees #80

Open
MomentusScott opened this issue Sep 1, 2023 · 0 comments
Open

Superfluous warning when elevation is equal to 90 degrees #80

MomentusScott opened this issue Sep 1, 2023 · 0 comments

Comments

@MomentusScott
Copy link

if np.any(5 > el) or np.any(np.mod(el, 90) < 5):

When calling gaseous_attenuation_approximation with an elevation angle of 90 degrees, this warning is thrown:

The approximated method to compute the gaseous attenuation in recommendation ITU-P 676-11 is only recommended for elevation angles between 5 and 90 degrees

First, 90 degrees is between 5 and 90 degrees (for the closed interval), so the conditional is inconsistent with the warning. Second, Annex 2 of ITU-R P.676-13 should work for 5 <= el <= 175 degrees, since sin(theta) is symmetric around 90deg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant