Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove period delimiters from project #62

Open
drewwells opened this issue Jul 7, 2020 · 0 comments
Open

remove period delimiters from project #62

drewwells opened this issue Jul 7, 2020 · 0 comments

Comments

@drewwells
Copy link
Contributor

drewwells commented Jul 7, 2020

Periods having meaning to many parsers. JSON and YAML for instance will assign different types to app-name vs app.name. TOML requires brackets to support periods. This is why you rarely, if ever, see periods used to delimit strings in any language. We have introduced periods to nearly every aspect of this project. As a result we are forced to do strange things to support something that has dubious technical reasons for its introduction.

We will remove periods from the project and replace them with the preferred delimiter of the code being generated.

Helm camelCase https://helm.sh/docs/chart_best_practices/values/#naming-conventions

chicken: true
chickenNoodleSoup: true

Viper is case insensitive, use stapler case for cli args spf13/viper#635. They use crazy case to showcase the insensitivity. - is a safer choice to avoid conflicting keys.

logrus-level: info

yaml camelCase - follow the conventions found in k8s itself

apiVersion: apps/v1

json camelCase - following k8s practice

{
  "apiVersion": "apps/v1"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant