Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code 1 Not managed in the way WKHTMLTOPDF intended #112

Open
brownerg opened this issue May 4, 2016 · 2 comments
Open

Exit code 1 Not managed in the way WKHTMLTOPDF intended #112

brownerg opened this issue May 4, 2016 · 2 comments

Comments

@brownerg
Copy link

brownerg commented May 4, 2016

Please see connected issue: #67 which stumbles across this issue.

I have an html document that contains an image url that 404's. WKHTMLTOPDF will return exit code 1 however looking at the issue below exit codes 0, 1 and Z still renders the pdf.

KnpLabs/snappy#177 (comment)

Despite I feel that django-wkhtmltopdf is doing the right thing, it does not reflect what wkhtmltopdf is documented todo.

I want to display the PDF even if one of the error codes is returned from wkhtmltopdf, but django-wkhtmltopdf trumps the output with an error. For this reason, I expect django-wkhtmltopdf to replicate the documented behaviour of wkhtmltopdf.

@johnraz
Copy link
Collaborator

johnraz commented May 11, 2016

This request does make sense at first glance. @brownerg do you mind trying to submit a PR for this?

@ghost
Copy link

ghost commented Jan 27, 2017

I'm not sure the exit codes mentioned in that link are correct. Here's my solution to this problem: #128

ashishnitinpatil added a commit to ashishnitinpatil/django-wkhtmltopdf that referenced this issue Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants