Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powermail opt-in confirmation breaks for cross browser functionality #51

Open
Mainbird opened this issue Jan 7, 2021 · 1 comment
Open

Comments

@Mainbird
Copy link

Mainbird commented Jan 7, 2021

Hi @einpraegsam,

we got some struggle with cross browser functionality and opt-in confirmation because sometimes $arguments were null inside ConditionAwareValidator.

We could reproduce this with the following setup:

  1. Create a form with some mandatory fields
  2. Create a condition to make one of these mandatory fields optional
  3. Submit the form (e.g. with Chrome)
  4. Confirm the opt-in email with another browser (e.g. with Firefox), maybe private mode will work as well here

After clicking the confirmation link the error message:

Validation failed while trying to call In2code\Powermail\Controller\FormController->createAction()

will be triggered, because $arguments were null and the validator will complain about a mandatory field that is not set because the powermail_cond-Session is missing. To fix this issue we have added the following condition to ConditionAwareValidator:

if ($arguments === null) {
    return;
}

What do you think about it?

@zabinetta
Copy link

We have the same problem. Firefox working, Chrome not.
the odd thing is: after the mail is confirmed, it's unhidden in Backend, but no further Mails are sent, so my receivers long time were not really aware of the problem, they just wondered why they got less emails..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants