[BUGFIX] https://github.com/einpraegsam/powermail_cond/issues/15 remo… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… request. note: upload fields can no longer be used as start_field or equal_field in rules. they can stil be used as target_field in conditions
…ternet explorer doesn't support this
|
Updated original pull request
|
|
Thx for your PR. Can you please make a small pull request. Let's say you want to fix Problem X. Explain the problem (or link it) and then just make a PR that only fixes this issue. Your PR seems to do a lot more. The compatibility for powermail 7 is already released. |
|
No problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #15
For comparison I included the file Resources/Public/JavaScript/PowermailCondition.deminified.js
The changes can be seen in line 28-32.
Safari throws an error, when you try to submit a FormData Object that includes file upload fields as payload of an ajax request. My change is to remove all file upload fields before request.
Note: upload fields can no longer be used as start_field or equal_field in rules. They can however still be used as target_field in conditions.