Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Insta filters to GEGL #90

Open
automata opened this issue Oct 30, 2015 · 5 comments
Open

Port Insta filters to GEGL #90

automata opened this issue Oct 30, 2015 · 5 comments

Comments

@automata
Copy link
Member

Bug tracking work on GEGL to implement Instagram inspired filters.

@jonnor
Copy link
Member

jonnor commented Feb 9, 2016

Basic set of ops reviewed and merged into GEGL. Needs integration and testing on imgflo side.

@jonnor
Copy link
Member

jonnor commented Feb 11, 2016

This should kinda be in imgflo-server repo, but whatever.

@jonnor
Copy link
Member

jonnor commented Feb 11, 2016

Tested the GEGL op insta-filter now.
1977 seems directly compatible.
nashville and brannan are significantly different, because the NoFlo graphs change brightness/saturation/contrast in addition to applying a color transfer curve.
hefe and xproii are not available.

@jonnor
Copy link
Member

jonnor commented Feb 11, 2016

We need to decide whether to a) change the filters to now be without constrast/brightness/saturation changes b) try to implement matching behavior using GEGL existing components c) port the Apply* ops to gegl directly.
Plan is to compare the two sets of filters on a set of images, to see if we prefer a or b/c.

@jonnor
Copy link
Member

jonnor commented Feb 11, 2016

On small images (150x150 px), with insta_1977, noflo takes 4200 ms and gegl 600 ms. Lots of this is due to component loading startup costs though. With a 9 mpixel, roughly typical of high-end smartphontes. NoFlo takes 9600ms and GEGL 5400 ms.

So there is significant savings available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants