Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

「フィルターされました」表示を非表示に変更 #211

Open
wants to merge 1 commit into
base: imastodon
Choose a base branch
from
Open

「フィルターされました」表示を非表示に変更 #211

wants to merge 1 commit into from

Conversation

lnanase
Copy link
Collaborator

@lnanase lnanase commented Jan 2, 2019

fixes #187

before after
02 03

少し迷ったのですが、このPRでは無条件で非表示にしています。
本家でも議論されているように、accountに表示するかどうかのフラグを設けるとか、
色々あると思いますが、私個人ではこのフィルターの表示は必要ないと思っています。

アイマストドンくらいの大規模インスタンスだと、
この修正で不具合が起こる可能性も考えられますので、
お手数ですがご確認をお願いしたく、よろしくお願い致します。

@lnanase lnanase added enhancement New feature or request help wanted Solutions or ideas are needed labels Jan 2, 2019
@lnanase lnanase requested a review from takayamaki January 2, 2019 09:33
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takayamaki takayamaki Awaiting requested review from takayamaki

Assignees

@deflis deflis

@fvh-P fvh-P

@takayamaki takayamaki

Labels
enhancement New feature or request help wanted Solutions or ideas are needed rebase needed 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

フィルター機能の「フィルターされました」を非表示に
4 participants
@lnanase @deflis @fvh-P @takayamaki