Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws.on :close not always triggered #4

Closed
rubys opened this issue Sep 28, 2016 · 2 comments
Closed

ws.on :close not always triggered #4

rubys opened this issue Sep 28, 2016 · 2 comments

Comments

@rubys
Copy link

rubys commented Sep 28, 2016

I've found two cases where ws.on :close is not triggered, both involving the server going down. First is with a em-websocket server, and the second is with a secure: true connection with a WebSocket-EventMachine-Server server.

A possible fix is to replace sleep 1 with close in client.rb.

@imanel
Copy link
Owner

imanel commented Sep 28, 2016

Interesting. Could you describe your configuration?

From what I understand you have websocket-client-simple connected to websocket-eventmachine-server, and when server is going down client is not receiving close callback. Is that correct?

If so then changing this line is definitely way to go.

@rubys
Copy link
Author

rubys commented Sep 28, 2016

My apologizes, I opened this issue against the wrong repository. I've opened a new issue against the correct repository, and added reproduction information.

@rubys rubys closed this as completed Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants