Skip to content
This repository has been archived by the owner on Mar 9, 2018. It is now read-only.

Feature Request: Read errors from APNS socket asynchronously #152

Open
jefflopes opened this issue Aug 12, 2013 · 1 comment
Open

Feature Request: Read errors from APNS socket asynchronously #152

jefflopes opened this issue Aug 12, 2013 · 1 comment

Comments

@jefflopes
Copy link

Having check_for_errors enabled is a huge performance hit. Would it be possible to read errors from the socket in such a way that doesn't block further sending? You would need to keep track of the order in which notifications were sent, because in the event of a disconnect and subsequent read from the socket, the failed notification might not be the last one sent and something that was previously marked delivered might need to be changed to failed.

PushSharp seems to handle this well: https://github.com/Redth/PushSharp/blob/master/PushSharp.Apple/ApplePushChannel.cs

@ileitch
Copy link
Owner

ileitch commented Aug 30, 2013

Thank you for the suggestion, I will implement this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants