Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Blacklist in Library #15

Open
ettisan opened this issue Dec 4, 2017 · 1 comment
Open

Include Blacklist in Library #15

ettisan opened this issue Dec 4, 2017 · 1 comment

Comments

@ettisan
Copy link

ettisan commented Dec 4, 2017

Though the blacklist is in the Git repo it is not included in the release JARs. Right now, a project that wants to include SerialKiller has to:

  • include the Jar (e.g. Maven)
  • copy the default configuration file and customize it

This is problematic since when the blacklist in the git repo is changed to include more vulnerable classes they are most likely not transferred to the config file.

I think it would therefore be better to include the blacklist into the JARs. By default the blacklist should be applied to all SerialKiller instances. This way, when the blacklist changes only the Jar has to be updated - the custom configuration file does not have to be modified.

I'm willing to implement this. Please give me a heads up as if you would want to accept such a pull request.

@ikkisoft
Copy link
Owner

ikkisoft commented Dec 5, 2017

Including the config in the jar is definitely a good suggestion to make sure that people relying on blacklisting use the latest version. Having said that, I didn't include the config because I would like to incentive the use of whitelisting instead.

I think it would make sense to have a default secure config included, and allow easy customization. I would be happy to accept and merge a PR. Still need to clean some stuff on master - I plan to use the Christmas break for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants