Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip ASGI websocket tests on PyPy #108

Open
ikalnytskyi opened this issue Nov 17, 2024 · 1 comment
Open

Unskip ASGI websocket tests on PyPy #108

ikalnytskyi opened this issue Nov 17, 2024 · 1 comment

Comments

@ikalnytskyi
Copy link
Owner

Revert "skipping" part of #107
@ikalnytskyi
Copy link
Owner Author

It seems there's a race condition in Starlette's WebSocketTestSession, and event CPython is affected. I wasn't able to reproduce this on CPython so far because the producer thread was always much faster for me there. See encode/starlette#2597 (comment) for details.

@ikalnytskyi ikalnytskyi removed the bug label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikalnytskyi