Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing of bash completion on Debian Buster failed when docker_version is set #7

Open
frzb opened this issue Dec 10, 2021 · 2 comments

Comments

@frzb
Copy link

frzb commented Dec 10, 2021

Given this minimal Ansible play running against Debian Buster

- hosts: test
  become: yes
  roles:
    - igor_nikiforov.docker
  vars:
    docker_version: 5:20.10.11~3-0~debian-buster

The Ansible run fails for the task installing the bash completion

TASK [igor_nikiforov.docker : Install Docker bash completion.] *****************
fatal: [test]: FAILED! => {"changed": false, "dest": "/etc/bash_completion.d/docker", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: Not Found", "status_code": 404, "url": "https://raw.githubusercontent.com/docker/cli/v5:20.10.11~3-0~debian-buster/contrib/completion/bash/docker"}

Looks like version strings on Debian and on the Github Docker CLI repository are no longer compatible.

@igor-nikiforov
Copy link
Owner

@frzb, thanks for report, I'll fix it asap.

@cinco
Copy link

cinco commented Sep 9, 2022

In the PR above, I applied a regex_replace in the docker_version variable, to use only the tag in the bash-completion installation. Since the correct value for docker_version, based on the versions listed in apt, would be docker_version: "5:20.10.17~3-0~ubuntu-focal"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants