From 426ae8f4378181eaa2366f85e61d87e297f64b1f Mon Sep 17 00:00:00 2001 From: "Joshua E. Hansel" Date: Thu, 9 Nov 2023 11:32:21 -0600 Subject: [PATCH] Addressed review --- framework/include/outputs/AdvancedOutput.h | 4 ++-- framework/src/outputs/AdvancedOutput.C | 4 ++-- test/tests/outputs/format/tests | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/framework/include/outputs/AdvancedOutput.h b/framework/include/outputs/AdvancedOutput.h index 53766866fb3d..49e1d5bb2848 100644 --- a/framework/include/outputs/AdvancedOutput.h +++ b/framework/include/outputs/AdvancedOutput.h @@ -410,7 +410,7 @@ AdvancedOutput::initPostprocessorOrVectorPostprocessorLists(const std::string & (_advanced_execute_on[execute_data_name].isValid() && _advanced_execute_on[execute_data_name].contains("none"))) { - const bool is_pp_type = (execute_data_name == "postprocessors") ? true : false; + const bool is_pp_type = (execute_data_name == "postprocessors"); const std::string pp_type_str = is_pp_type ? "post-processor" : "vector post-processor"; mooseWarning("The ", pp_type_str, @@ -420,7 +420,7 @@ AdvancedOutput::initPostprocessorOrVectorPostprocessorLists(const std::string & name(), "' output, but ", pp_type_str, - " output is disabled for this output object."); + " output is disabled for that output object."); } } } diff --git a/framework/src/outputs/AdvancedOutput.C b/framework/src/outputs/AdvancedOutput.C index 6a458f8ea5d6..59a2dd6bdb3b 100644 --- a/framework/src/outputs/AdvancedOutput.C +++ b/framework/src/outputs/AdvancedOutput.C @@ -151,8 +151,8 @@ void AdvancedOutput::init() { // Initialize the execution flags - for (auto & it : _advanced_execute_on) - initExecutionTypes(it.first, it.second); + for (auto & [name, input] : _advanced_execute_on) + initExecutionTypes(name, input); // Clear existing execute information lists _execute_data.reset(); diff --git a/test/tests/outputs/format/tests b/test/tests/outputs/format/tests index 18ae9e5ca1ae..2c40319df14e 100644 --- a/test/tests/outputs/format/tests +++ b/test/tests/outputs/format/tests @@ -109,7 +109,7 @@ [pps_screen_out_warn_test] type = 'RunApp' input = 'pps_screen_out_warn.i' - expect_out = "The post-processor 'avg_block' has requested to be output by the 'console' output, but post-processor output is disabled for this output object" + expect_out = "The post-processor 'avg_block' has requested to be output by the 'console' output, but post-processor output is disabled for that output object" allow_warnings = true max_parallel = 1 # warning can mix on multiple processes issues = '#1426'