Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization of staging models, datasets, and other assets #23

Open
luszczek opened this issue Oct 15, 2023 · 0 comments
Open

Customization of staging models, datasets, and other assets #23

luszczek opened this issue Oct 15, 2023 · 0 comments

Comments

@luszczek
Copy link
Contributor

Currently, templating during staging of models, datasets, and other assets is done through single {}'s braces in JSON files. This is easy to understand but a non-Pythonic way. Using string {dataset.source} in JSON file looks for dataset.source (attribute source of object dataset according to Python's format) even though Python's official format() syntax should be for dataset["source"]. This requires specialized code in executors.py that is not a part of the standard Python library or provided consistently with a short and simple code. The other problem is no means of customization for environments for staging or running commands. Some behavior of many commands can only be changed through environment variables. Both of these problems can be fixed by switching to string.Template for both JSON and shell customization which is consistent with the Python standard library and various command line shells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant