Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed number of HTTP/2 continuation frames #279

Open
mkauf opened this issue Apr 5, 2024 · 1 comment
Open

Allowed number of HTTP/2 continuation frames #279

mkauf opened this issue Apr 5, 2024 · 1 comment

Comments

@mkauf
Copy link
Contributor

mkauf commented Apr 5, 2024

nghttp2 1.61.0 limits the number of HTTP/2 continuation frames and provides the new function nghttp2_option_set_max_continuations(). By default, 8 continuation frames are allowed.

Envoy increased the value to 1024 in this commit: envoyproxy/envoy@7d0c522

Are 8 HTTP/2 continuation frames enough? Should the value be part of the configuration, or could mod_h2 calculate a value based on LimitRequestLine, LimitRequestFields and LimitRequestFieldSize ?

@icing
Copy link
Owner

icing commented Apr 5, 2024

Since mod_h2 now RSTs the stream after 100 incoming headers exceeding the limit, we could safely raise the number of frames. Some people, I learned, work with really huge headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants