Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Format roundFactor #7462

Open
ColinKerr opened this issue Dec 6, 2024 · 2 comments
Open

Add tests for Format roundFactor #7462

ColinKerr opened this issue Dec 6, 2024 · 2 comments
Assignees
Labels
ecschema Issues related to the various ecschema packages

Comments

@ColinKerr
Copy link
Member

We have tests confirming that the Format.roundFactor attribute is round tripped but no tests validating that it is properly handled in the C++ or TypeScript formatting code.

See documentation for roundFactor here: https://www.itwinjs.org/bis/ec/ec-format

Add tests in C++ and TypeScript

@ColinKerr ColinKerr added the ecschema Issues related to the various ecschema packages label Dec 6, 2024
@hl662
Copy link
Contributor

hl662 commented Dec 9, 2024

Adding information, based on my very short search, core-quantity has some tests set up for rounding, but none of the FormatSpecs used in the tests seem to pass in a roundFactor to it's properties.

@naronchen naronchen self-assigned this Dec 16, 2024
@naronchen
Copy link
Contributor

naronchen commented Dec 27, 2024

roundFactor is used in formatMagnitude which is referenced in

  • formatQuantity link
    • also formatCompositePart link, called by formatComposite in formatQuantity
  • formatRatio link

will add a couple tests there.

will do the same on cpp side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecschema Issues related to the various ecschema packages
Projects
None yet
Development

No branches or pull requests

3 participants