Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecschema-metadata does not pull KOQ from base properties if not defined in a property override #7424

Open
ColinKerr opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
ecschema Issues related to the various ecschema packages

Comments

@ColinKerr
Copy link
Member

ColinKerr commented Nov 25, 2024

The C++ ECObjects implementation gets the base KOQ if not defined locally: https://github.com/iTwin/imodel-native/blob/0598b2eb063f79e42141b2c5692db7df4c34a07f/iModelCore/ecobjects/src/ECProperty.cpp#L916

The TypeScript code does not:

public get kindOfQuantity(): LazyLoadedKindOfQuantity | undefined { return this._kindOfQuantity; }

Ensure that serialization does not serialize base KOQ when serializing property override.

Review C++ for other property attributes that are pulled from base property if not locally defined and ensure TypeScript does the same. Make sure there are tests on both sides that ensure attributes pulled from base properties are not serialized with property overrides

@ColinKerr ColinKerr added the ecschema Issues related to the various ecschema packages label Nov 25, 2024
@naronchen naronchen self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecschema Issues related to the various ecschema packages
Projects
None yet
Development

No branches or pull requests

2 participants