Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] From array doesn't support null values #44

Open
Gounlaf opened this issue Sep 1, 2020 · 0 comments
Open

[Bug] From array doesn't support null values #44

Gounlaf opened this issue Sep 1, 2020 · 0 comments

Comments

@Gounlaf
Copy link

Gounlaf commented Sep 1, 2020

Hi,

   /**
    * Creates a option if the `$key` exists in `$array`
    *
    * ```php
    * $some = Option::fromArray(['hello' => ' world'], 'hello');
    * $none = Option::fromArray(['hello' => ' world'], 'nope');
    * ```
    * _Notes:_
    *
    * - Returns `Option<T>`
    * @psalm-pure
    * @psalm-mutation-free
    *
    * @psalm-param array<array-key, mixed> $array
    * @psalm-param array-key $key The key of the array
    * @psalm-return Option<T>
    **/
   public static function fromArray(array $array, $key): self {
      if (isset($array[$key])) {
         return self::some($array[$key]);
      }

      return self::none();
   }

Using isset will return false when a key exist with a null value. array_key_exists does what the method description says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant