Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding zoom option using scroll wheel #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

juanmaus
Copy link

Adding a PinchArea to allow zooming with scroll wheel while in fullscreen. Useful for 4k+ cams/small screens.

@iEvgeny
Copy link
Owner

iEvgeny commented May 18, 2023

Great idea!
But I think we need to add the "Ctrl" modifier key for this action.

@iEvgeny
Copy link
Owner

iEvgeny commented May 18, 2023

Hmm. This implementation seems to break the current behavior of viewports selection on the grid.
The code needs to be improved.

@juanmaus
Copy link
Author

Hmm. This implementation seems to break the current behavior of viewports selection on the grid. The code needs to be improved.

Whoops, forgot that was a feature, I'll try to fix it in the future, first time handling qml code for me, also Ctrl modifiers seems like a great idea

@mabed-fr
Copy link

mabed-fr commented Jan 2, 2024

Zoom with onvif or numerical zoom ?

@juanmaus
Copy link
Author

juanmaus commented Jan 2, 2024

Zoom with onvif or numerical zoom ?

Numerical

@mabed-fr
Copy link

When can it be merged?

@iEvgeny
Copy link
Owner

iEvgeny commented Mar 22, 2024

Unfortunately, this pull request breaks the existing functionality and needs to be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants