Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catppuccin broken again #11

Open
spikespaz opened this issue Aug 30, 2024 · 7 comments
Open

Catppuccin broken again #11

spikespaz opened this issue Aug 30, 2024 · 7 comments
Assignees

Comments

@spikespaz
Copy link
Member

spikespaz commented Aug 30, 2024

Originally posted by @hmajid2301 in #10 (comment)

Hey I seem to be getting issues with catpuccin/nix now

┏━ 1 Errors:
 ⋮
┃              |           ^
┃          1576|         else
┃
┃        … while evaluating the attribute 'value'
┃          at /nix/store/ia1zpg1s63v6b3vin3n7bxxjgcs51s2r-source/lib/modules.nix:821:9:
┃           820|     in warnDeprecation opt //
┃           821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
┃              |         ^
┃           822|         inherit (res.defsFinal') highestPrio;
┃
┃        … while evaluating the option `system.build.toplevel':
┃
┃        … while evaluating definitions from `/nix/store/ia1zpg1s63v6b3vin3n7bxxjgcs51s2r-source/nixos/modules/system/activation/top-level.nix':
┃
┃        … while evaluating the option `assertions':
┃
┃        … while evaluating definitions from `/nix/store/cllqwnqqr2nci1l1b3fpr9f28vd4arfq-source/nixos/common.nix':
┃
┃        (stack trace truncated; use '--show-trace' to show the full, detailed trace)
┃
┃        error: The option `home-manager.users.haseeb.wayland.windowManager.hyprland.settings."\$accent"' does not exist. Definition values:
┃        - In `/nix/store/2phys7y5pxk5dvp489ipx67hl9gzw4jr-source/modules/home-manager/hyprland.nix':
┃            {
┃              _type = "if";
┃              condition = false;
┃              content = "$mauve";
┃            } 

I tried to follow the issue #9

dots: https://gitlab.com/hmajid2301/dotfiles/-/blob/docker-vps/modules/home/desktops/hyprland/config.nix?ref_type=heads#L14

looks like it could be this change causing issues ? catppuccin/nix@512306a adding new attributes

@spikespaz
Copy link
Member Author

@hmajid2301 I forgot to ask before creating a new issue, but you did successfully use wayland.windowManager.hyprland.fufexan.enable = true on the rewrite branch, correct?

@spikespaz spikespaz self-assigned this Aug 30, 2024
@spikespaz
Copy link
Member Author

Try this:

diff --git a/flake.nix b/flake.nix
index 1b73677..a69e6cd 100644
--- a/flake.nix
+++ b/flake.nix
@@ -76,15 +76,7 @@
       inputs.nixpkgs.follows = "nixpkgs";
     };
 
-    hyprland-git.url = "github:hyprwm/hyprland";
-    hyprland-xdph-git.url = "github:hyprwm/xdg-desktop-portal-hyprland";
-    hyprland-protocols-git.url = "github:hyprwm/xdg-desktop-portal-hyprland";
-    hyprland-nix.url = "github:hyprland-community/hyprnix/rewrite";
-    hyprland-nix.inputs = {
-      hyprland.follows = "hyprland-git";
-      hyprland-xdph.follows = "hyprland-xdph-git";
-      hyprland-protocols.follows = "hyprland-protocols-git";
-    };
+    hyprnix.url = "github:hyprland-community/hyprnix/rewrite";
     hyprpanel.url = "github:Jas-SinghFSU/HyprPanel";
 
     nixvim = {
diff --git a/modules/home/desktops/hyprland/default.nix b/modules/home/desktops/hyprland/default.nix
index 82f3850..2e7ab6c 100644
--- a/modules/home/desktops/hyprland/default.nix
+++ b/modules/home/desktops/hyprland/default.nix
@@ -11,7 +11,7 @@ with types; let
 in {
   imports = with inputs;
     [
-      hyprland-nix.homeManagerModules.default
+      hyprnix.homeManagerModules.default
     ]
     ++ lib.snowfall.fs.get-non-default-nix-files ./.;

@hmajid2301
Copy link

Looks to be the same error:

commit: https://gitlab.com/hmajid2301/dotfiles/-/merge_requests/218/diffs?commit_id=f42737bbf401c4c2a11a49c97e06618c74d97d0c

┏━ 1 Errors:
┃ error:
┃        … while evaluating a branch condition
┃          at /nix/store/ia1zpg1s63v6b3vin3n7bxxjgcs51s2r-source/lib/lists.nix:125:9:
┃           124|       fold' = n:
┃           125|         if n == len
┃              |         ^
┃           126|         then nul
┃
┃        … while calling the 'length' builtin
┃          at /nix/store/ia1zpg1s63v6b3vin3n7bxxjgcs51s2r-source/lib/lists.nix:123:13:
┃           122|     let
┃           123|       len = length list;
┃              |             ^
┃           124|       fold' = n:
┃
┃        (stack trace truncated; use '--show-trace' to show the full trace)
┃
┃        error: The option `wayland.windowManager.hyprland.settings."\$accent"' does not exist. Definition values:
┃        - In `/nix/store/2phys7y5pxk5dvp489ipx67hl9gzw4jr-source/modules/home-manager/hyprland.nix':
┃            {
┃              _type = "if";
┃              condition = false;
┃              content = "$mauve";
┃            }
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 15:43:11 after 1s
Error:
   0: Command exited with status Exited(1)

Location:
   src/commands.rs:151

@hmajid2301
Copy link

@hmajid2301 I forgot to ask before creating a new issue, but you did successfully use wayland.windowManager.hyprland.fufexan.enable = true on the rewrite branch, correct?

No I got the error straight away, as I already had catppuccin nix. Or do you mean did I try it without catppuccin nix?

@hmajid2301
Copy link

@spikespaz sorry to bother you any update on this?

@spikespaz
Copy link
Member Author

@spikespaz sorry to bother you any update on this?

Catppuccin unknowingly rugpulled the current fix. You could revert to a catppuccin revision that still uses sourced/included external files. Now, they rely on the serialization mechanism written by Fufexan, so a shim isn't so easy.

I can probably get to it next week. I just moved and started a new job, so just give some time for dust to settle for me.

I'm sincerely sorry for the inconvenience and delay.

@spikespaz spikespaz pinned this issue Sep 29, 2024
@hmajid2301
Copy link

Mate no need to apologise:). This is all opennsoirxd you contribute when you can. Hahaha, thanks for all your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants