Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible with different file sizes? #2

Open
ldionmarcil opened this issue Jan 18, 2017 · 5 comments
Open

Possible with different file sizes? #2

ldionmarcil opened this issue Jan 18, 2017 · 5 comments

Comments

@ldionmarcil
Copy link
Contributor

Hey, I have found a vector vulnerable to this bug but requires specific sizes (ie 1000x1000, or 100x100). Did you have in mind to add this as a feature?

@Nader-abdi
Copy link

Did you find a solution for this problem?!

@Nader-abdi
Copy link

Hey, I have found a vector vulnerable to this bug but requires specific sizes (ie 1000x1000, or 100x100). Did you have in mind to add this as a feature?

.

@huntergregal
Copy link
Owner

Let me take a peek at this. This tool could use a little review anyway.

@Nader-abdi
Copy link

yes thank you

@huntergregal
Copy link
Owner

huntergregal commented Jan 28, 2023

Looked a bit at this today - I was able to generate payloads up to 63x63 but it's pretty iffy.

I suspect at larger pixel sizes there are more PNG filters that can apply - and potentially more than 1. Unfortunately generating larger images at this time is not going to be a simple task.

see: http://www.libpng.org/pub/png/spec/1.2/PNG-Filters.html

idontplaywith darts was able to coerce most encoders to always use the filter of our choice (this is the bypass_filters() passes in the code - improved upon by others in this repo).

But once you get to larger images I think various encoders will start to do their own optimizations and potentially pass the image through other filters. (there are 5 in total). Support for this is non-trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants